make it work on macOS - Githubissues

riboseinc / aws-authenticating-secgroup-scripts

Scripts to use riboseinc/terraform-aws-authenticating-secgroup

Apache License 2.0

32 stars 28 forks source link

Closed erikbor closed 6 years ago

erikbor commented 6 years ago

@phuonghuynh I added support for macOS, can you please verify that my changes do not impact running on Linux?

Thanks

phuonghuynh commented 6 years ago

Could we reformat the code as defined in .editorconfig ?

editorconfig has some plugin for some IDEs like vim, IntelliJ...

ronaldtse commented 6 years ago

@phuonghyunh good call. Could you actually directly edit this PR to fix these? Thanks!

phuonghuynh commented 6 years ago

Yes, I agree but i not test for RHEL & CentOS

phuonghuynh commented 6 years ago

@erikbor @ronaldtse I updated this PR, tested on both MacOS 10.13.2 & Ubuntu 16.04.1 LTS

Could we update the OS list in #7 ?

ronaldtse commented 6 years ago

Thanks @phuonghuynh !