search

riboseinc / aws-authenticating-secgroup-scripts

Scripts to use riboseinc/terraform-aws-authenticating-secgroup
Apache License 2.0
32 stars 28 forks source link

Vagrant for testing purpose #7

Open phuonghuynh opened 6 years ago

phuonghuynh commented 6 years ago

We also should add build badge as well

ronaldtse commented 6 years ago

Fully agree! :+1:

ronaldtse commented 6 years ago

You probably meant Travis? I’m wondering how we can actually test since it involves AWS. We will have to separately test the Terraform module, the Lambda scripts, and also the client scripts.

phuonghuynh commented 6 years ago

I think we dont need to make calls to AWS API since the main task is building Signature v4 which is depends on OpenSSL. I wonder if there is any incompatible OpenSSL version that @erikbor fixed.

We can use aws signature-v4-test-suite

Issue submitted riboseinc/terraform-aws-authenticating-secgroup#13 to discuss terraform module testing

ronaldtse commented 6 years ago

I was working with @erikbor yesterday and we fixed it for OpenSSL 1.1. Not sure if it works for OpenSSL 1.0.x though.

phuonghuynh commented 6 years ago

Yep, thats exactly whats we need to do test