search

riboseinc / digicert

Ruby bindings for the Digicert Services API
https://www.digicert.com/services/v2/documentation
MIT License
8 stars 10 forks source link

Fix reissue/duplication issue for custom attribute #124

Closed abunashir closed 7 years ago

abunashir commented 7 years ago

Normally the Order reissue and duplication interface takes an order id and then usages the details from that order, and additionally it also supports for custom attributes. The way it supposed to work is if we add any custom attributes then it will use that along with all others but if we don't then it will use the defaults.

It is working fine when no attributes is provided, but when we provide custom attributes then it is replacing all of the attributes with the new one, which might not include all the attributes, that's why we are having issue like https://github.com/riboseinc/digicert-cli/issues/46

This commit fix that issue, and it also updates the existing interface to provide the custom attributes along with the order_id, and it will do the work of organizing those, bit less work for users!

abunashir commented 7 years ago

@ronaldtse: This includes a fix for reissue issues we were having on the CLI, and this also changes those interface, please have a look and let me know, once this is merged then I will also bump the gem version.

ronaldtse commented 7 years ago

@abunashir I just tested this last night and I believe it works. The remaining kinks are with the CLI itself so I've put up the issues here riboseinc/digicert-cli#48 and riboseinc/digicert-cli#49.

I also realized that we could have used the 'certificate duplicate' method instead of 'certificate reissue' to change hostname (common name) and the key, so the issue is at riboseinc/digicert-cli#49.

Thanks!

ronaldtse commented 7 years ago

@abunashir let me merge this then.