search

riboseinc / digicert

Ruby bindings for the Digicert Services API
https://www.digicert.com/services/v2/documentation
MIT License
8 stars 10 forks source link

Add spec to create order with immediate issuance #128

Closed abunashir closed 6 years ago

abunashir commented 6 years ago

Recently, DigiCert introduced the immediate certificate issuance feature for the eligible order. If any of the order falls under that category then the certificate content will be provided with the order creation request.

This does not require any changes on the client, but we have added a feature spec and also some instruction to the readme.

GitHub Issue: https://github.com/riboseinc/digicert/issues/127 Note: https://www.digicert.com/certcentral-support/immediate-certificate-issuance-feature.htm

abunashir commented 6 years ago

@ronaldtse: I have been looking into the issue and we actually do not need to do any changes for the immediate issuance. I have added some basic documentation and a spec for this scenario, please have a look and let me know if you want to add something else.

ronaldtse commented 6 years ago

@abunashir but we should change the "request-issuance", "request-reorder" and "request-duplication" specs so that we can directly fetch the certificate if it the certificate-id has been provided? Previously only the request-id was provided.

ronaldtse commented 6 years ago

Thank you @abunashir !