add support for Private Premium client certificate

riboseinc / digicert

Ruby bindings for the Digicert Services API

https://www.digicert.com/services/v2/documentation

MIT License

8 stars 10 forks source link

add support for Private Premium client certificate #130

Closed davidcpell closed 6 years ago

davidcpell commented 6 years ago

Hi again!

Our company is paying Digicert for private PKI services, i.e. a CA hosted by Digicert to which only we have access for issuing certificates. This allows us to use their "Private Client Premium" certificate endpoint which isn't documented in the API docs (for whatever reason).

The gem's organization made it super easy for us to implement this class locally (thanks!) but I thought I'd see what you think about incorporating the change to get to this endpoint.

ronaldtse commented 6 years ago

@davidcpell thank you so much for this PR! It looks good to me, let's see if @abunashir @ribose-jeffreylau has any comments.

ribose-jeffreylau commented 6 years ago

LGTM!

Thanks @davidcpell !