search

riboseinc / digicert

Ruby bindings for the Digicert Services API
https://www.digicert.com/services/v2/documentation
MIT License
8 stars 10 forks source link

Discrepancy between Digicert::DuplicateCertificate.all and order.duplicate_certificates #141

Closed kwkwan closed 6 years ago

kwkwan commented 6 years ago

This works:

    dup_certificates = Digicert::DuplicateCertificate.all(
      order_id: order_id,
      sort: 'date_created',
      limit: 1,
      offset: 0,
    )

But this doesn't:

    dup_certificates = order.duplicate_certificates(
      sort: 'date_created',
      limit: 1,
      offset: 0,
    )

It'll be great if both work the same way. Thanks!

abunashir commented 6 years ago

Thanks for reporting this @kwkwan, I just added the support for the option in the attached pull request, Thanks!