search

riboseinc / digicert

Ruby bindings for the Digicert Services API
https://www.digicert.com/services/v2/documentation
MIT License
8 stars 10 forks source link

Fix duplicate certificate finder issue #144

Closed abunashir closed 6 years ago

abunashir commented 6 years ago

Recently, we came across an issue in the duplicate certificate finder. Let's say one certificate has an existing duplicate and in a later date we also request another one which is pending. Now if we use the finder to find the duplicate certificate then it would return the old one, which is miss leading.

This commit fixes this by checking the status of the request and if it's still pending then it throws an error.

Discussion: #138

abunashir commented 6 years ago

@ronaldtse, @kwkwan: Did you guys have a chance to look into this one?

kwkwan commented 6 years ago

@abunashir Looks good to me.