riboseinc / digicert

Ruby bindings for the Digicert Services API
https://www.digicert.com/services/v2/documentation
MIT License
8 stars 10 forks source link

Cleanup `Digicert::Base` super class #57

Closed abunashir closed 7 years ago

abunashir commented 7 years ago

There are lot's of behavior we have in Digicert::Base class aren't necessary for it's subs classes, this exposes some interfaces that might create some problem, so the main purpose of this PR is to simplify the Digicert::Base class so it would be shareable, and extract customs behavior so we can add those whenever necessary.

ronaldtse commented 7 years ago

Very nice.