riboseinc / digicert

Ruby bindings for the Digicert Services API
https://www.digicert.com/services/v2/documentation
MIT License
8 stars 10 forks source link

Do not expose the internal implementation #70

Closed abunashir closed 7 years ago

abunashir commented 7 years ago

If we want to use the current Digicert::CertificateDownloader form any other classes then we need to know too much about the internal implementation, like how to construct a new object, use its instance method to fetch or fetch_to_path or any other behavior where we have clearly defined class methods but there are some limitations

This commit fix these limitations for the class methods, so now we can replace the certificate instance methods to use these instead of dealing with downloaders internal implementation.

ronaldtse commented 7 years ago

Nicely done, thanks Abu.