riboseinc / digicert

Ruby bindings for the Digicert Services API
https://www.digicert.com/services/v2/documentation
MIT License
8 stars 10 forks source link

Add request spec to order premium certificate #97

Closed abunashir closed 7 years ago

abunashir commented 7 years ago

Run the test

bin/rspec --tag api_call spec/requests/order_client_premium_certificate_spec.rb
abunashir commented 7 years ago

@ronaldtse : Could you please have a look into this, this say that product is not allowed.

screenshot 2017-03-22 15 58 58
ronaldtse commented 7 years ago

@abunashir got it, let me find out.

I just noticed: in the Digicert::Errors::RequestError raised, can we show the error body such as code: product_not_allowed and message?

ronaldtse commented 7 years ago

@abunashir So the problem is because of existing certificates having spent too much credit. The maximum negative balance is $2,000. Could you revoke all existing certificates to get back the credits and try again?

abunashir commented 7 years ago

@ronaldtse : I tried this one again with changing the attributes and we have the sufficient balance (3 years cost $24, but we have around 600 left) but it still not working I also tried with CSR and without CSR.

I think, maybe I am missing something, could you please have a look. Here is the last request I did

screenshot 2017-03-24 14 23 15
ronaldtse commented 7 years ago

@abunashir Let me contact them about this too.

ronaldtse commented 7 years ago

I've sent them a message and hope to get this resolved soon. Will ping you @abunashir .

abunashir commented 7 years ago

Thanks Ron!

ronaldtse commented 7 years ago

Not resolved yet, I've CC'ed you too.

abunashir commented 7 years ago

Thanks for the update @ronaldtse, I have been following that email :)

ronaldtse commented 7 years ago

@abunashir it works now! Can you help update any necessary tests and merge it? Thanks.

ronaldtse commented 7 years ago

@abunashir it's merged now 👍

abunashir commented 7 years ago

Awesome @ronaldtse, Finally it's moving forward :)

I will try to go through all kind of certificate sometime this week and then we can push another version to RubyGems.