search

riboseinc / digicert

Ruby bindings for the Digicert Services API
https://www.digicert.com/services/v2/documentation
MIT License
8 stars 10 forks source link

Certificate download method in README does not reflect actual operations #99

Closed ronaldtse closed 7 years ago

ronaldtse commented 7 years ago

Hi @abunashir ,

In the README it says you can do:

certificate = Digicert::Certificate.find(certificate_id)
==> certificate_content_object = certificate.download(platform: "apache") <==

But this call is not yet implemented. Could we implement this?

certificate.download(platform:)
# and
certificate.download(format:)
abunashir commented 7 years ago

@ronaldtse, I am not sure if I understand correctly, but we already have the download instance method that expects a hash arguments where we can add platform or format key and then it will delegate that behavior to the DigicertCertificateDownloader.

The Digicert::CertificateDownloader's fetch method will use the proper path based on the hash key provided along with the other attributes.

Reference:

Certificate: #download Certificate Downloader: #fetch Spec that is using this interface: certificate_spec

Please have a look and let me know.

ronaldtse commented 7 years ago

Completed and closed.