search

riboseinc / jekyll-theme-open-project-helpers

Helper utils for Open Project gem-based Jekyll theme
MIT License
1 stars 1 forks source link

(URGENT) Build fails at `spec` file when a specified image is missing, or an additional image is not listed #21

Closed ronaldtse closed 3 years ago

ronaldtse commented 3 years ago

e.g. https://github.com/metanorma/metanorma.org/runs/3279098951?check_suite_focus=true

/opt/hostedtoolcache/Ruby/2.7.4/x64/lib/ruby/gems/2.7.0/gems/jekyll-theme-open-project-helpers-2.1.7/lib/jekyll-theme-open-project-helpers/spec_builders/png_diagrams.rb:72:in `block in build_spec_pages': Navigation item matching StandardDoc_Form.png (specs/metanorma-model-standoc) was not found (RuntimeError)
26

This problem has consumed numerous (at least a dozen) hours of @opoudjis and my time in tweaking the source index. We need to ensure:

  1. If there is a specified image but it doesn't exist, raise an error but DO NOT CRASH.
  2. If there is an image that was not specified but it exists, DO NOT RAISE ANY ERROR. This is expected to not fail.
CAMOBAP commented 3 years ago

In progress

CAMOBAP commented 3 years ago
  1. [x] both issues should be fixed with or https://github.com/riboseinc/jekyll-theme-open-project-helpers/pull/22
  2. [ ] cover with tests
CAMOBAP commented 3 years ago

@ronaldtse I have no permission to release the gem. Version increased and pushed to the repo

ronaldtse commented 3 years ago

@camobap the gem is now released. I had to also update+release jekyll-theme-open-project to use this new version. Thanks!

ronaldtse commented 3 years ago

@CAMOBAP I've added the RIBOSE_RUBYGEMS_API_KEY secret here for releasing the gem, could you help update the GHA CI? Thanks!