search

riboseinc / jekyll-theme-open-project

Jekyll theme for site suite presenting your open software and specifications.
MIT License
30 stars 3 forks source link

Favicon is missing #37

Closed strogonoff closed 5 years ago

strogonoff commented 5 years ago

Following set, and a /favicon.ico under site root, may be enough:

<link rel="apple-touch-icon-precomposed" sizes="76x76" href="">
<link rel="apple-touch-icon-precomposed" sizes="120x120" href="">
<link rel="apple-touch-icon-precomposed" sizes="152x152" href="">
<link rel="apple-touch-icon-precomposed" sizes="167x167" href="">
<link rel="apple-touch-icon-precomposed" sizes="180x180" href="">
<link rel="icon" sizes="192x192" href="">
<link rel="mask-icon" href="" color="">
<link rel="shortcut icon" type="image/x-icon" href="">

Related to #14.

strogonoff commented 5 years ago

Dealing with ImageMagick Ruby bindings seems futile, at least under macOS. Some ways around it:

1) Give up on macOS support. It’s useful for working with local site copies so we sort of implicitly support it, but it’s not essential since using VM is an easy option with Vagrant or Docker.

2) Give up on automatic SVG rasterization and require OP sites to provide an additional PNG render of symbol.svg. It gives a fine-grained control over favicon/touch icon look (doubt that’s essential). On the other hand, it is not DRY and introduces unnecessary human factor.

strogonoff commented 5 years ago

There is better meta tag support & documentation for favicon now. The solution is suboptimal since it requires a manual render of multiple PNG representations of the original SVG asset, complicating site setup, but I don’t see a good way around it for now.