search

riboseinc / jekyll-theme-open-project

Jekyll theme for site suite presenting your open software and specifications.
MIT License
30 stars 3 forks source link

Allow using FontAwesome free / pro via `_config.yml` #67

Closed ronaldtse closed 5 years ago

ronaldtse commented 5 years ago

This is a clean up (and follow up) of #65 .

I've extracted out these variables to be determined in _config.yml:

By default, they are set to this in the gem's _config.yml:

icon_font:
  icon_class: 'fas'
  fa_integrity: 'sha384-g5uSoOSBd7KkhAMlnQILrecXvzst9TdC09/VM+pjDTCM+1il8RHz5fKANTFFb+gQ'
  fa_src: https://use.fontawesome.com/releases/v5.8.1/js/all.js

If you want to use pro (e.g. in relaton.com), we set _config.yml in the "user site" (i.e. relaton.com) to:

icon_font:
  icon_class: 'far'
  fa_integrity: 'sha384-E5SpgaZcbSJx0Iabb3Jr2AfTRiFnrdOw1mhO19DzzrT9L+wCpDyHUG2q07aQdO6E'
  fa_src: https://pro.fontawesome.com/releases/v5.1.0/js/all.js

@strogonoff please help review (I've tried it with relaton.com, and it worked). Thanks!

strogonoff commented 5 years ago

Thanks for the help Ronald!

On 5 Apr 2019, at 11:27 PM, Ronald Tse notifications@github.com wrote:

This is a clean up (and follow up) of #65 .

I've extracted out these variables to be determined in _config.yml:

Icon font URL Icon font integrity hash FontAwesome Icon class (far or fas) By default, they are set to this in the gem's _config.yml:

icon_font: icon_class: 'fas' fa_integrity: 'sha384-g5uSoOSBd7KkhAMlnQILrecXvzst9TdC09/VM+pjDTCM+1il8RHz5fKANTFFb+gQ' fa_src: https://use.fontawesome.com/releases/v5.8.1/js/all.js If you want to use pro (e.g. in relaton.com), we set _config.yml in the "user site" (i.e. relaton.com) to:

icon_font: icon_class: 'far' fa_integrity: 'sha384-E5SpgaZcbSJx0Iabb3Jr2AfTRiFnrdOw1mhO19DzzrT9L+wCpDyHUG2q07aQdO6E' fa_src: https://pro.fontawesome.com/releases/v5.1.0/js/all.js @strogonoff please help review (I've tried it with relaton.com, and it worked). Thanks!

You can view, comment on, or merge this pull request online at:

https://github.com/riboseinc/jekyll-theme-open-project/pull/67

Commit Summary

feat: update fa version and add variable for pro. closes #64 fix: change regular search icon to solid fix: fa pro uses individual hashes for users Merge pull request #65 from ubiety/master Extract out icon font URL, integrity hash and FA icon class File Changes

M README.md (17) M _config.yml (5) M _includes/external-link.html (8) M _includes/home-hero.html (2) M _includes/item-doc-page.html (6) M _includes/nav-links.html (2) M _layouts/default.html (15) M _layouts/docs-base.html (4) M _layouts/post.html (2) Patch Links:

https://github.com/riboseinc/jekyll-theme-open-project/pull/67.patch https://github.com/riboseinc/jekyll-theme-open-project/pull/67.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ronaldtse commented 5 years ago

@strogonoff if it's OK can you help merge it? Thanks!