riboseinc / open.ribose.com

Ribose Open site
2 stars 4 forks source link

Update project logos #13

Closed ronaldtse closed 6 years ago

ronaldtse commented 6 years ago

Update project logos for Metanorma and RNP, provided here:

https://github.com/riboseinc/open-design

strogonoff commented 6 years ago

@ronaldtse can we trigger a rebuild of the hub? Open Project framework would display each project’s logo as specified in their corresponding site assets after that.

ronaldtse commented 6 years ago

The trigger is automatic, I wonder if the build is failing. I know @ribose-jeffreylau is having trouble building the site?

strogonoff commented 6 years ago

This did not involve a commit in the hub repo, because logos are updated in the repos of respective projects. Hence I asked for manual build on hub site in this scenario. I’ll make a chore commit for this then.

On 3 Sep 2018, at 7:30 PM, Ronald Tse notifications@github.com wrote:

The trigger is automatic, I wonder if the build is failing. I know @ribose-jeffreylau is having trouble building the site?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

strogonoff commented 6 years ago

If there is trouble building the site, feel free to file an issue with the error, maybe I’ve already dealt with it, or if not I’ll try to reproduce it in my environment and see. I imagine the troubling part would be the helpers gem as it contains the bulk of logic in Ruby. @ronaldtse @ribose-jeffreylau

strogonoff commented 6 years ago

Fresh logos should be pulled with https://github.com/riboseinc/open.ribose.com/commit/99f51ba274d4cb7a19684301e33e635bf3f53b6e

ribose-jeffreylau commented 6 years ago

@strogonoff Thanks. Indeed the error is in the helper gem. I've just posted an issue there.

https://github.com/riboseinc/jekyll-theme-open-project-helpers/issues/5