Closed ronaldtse closed 2 years ago
The build failure is exactly due to the underlying problem stated here: https://github.com/riboseinc/open.ribose.com/issues/68
/home/runner/work/open.ribose.com/open.ribose.com/vendor/bundle/ruby/3.0.0/gems/git-1.9.1/lib/git/lib.rb:1110:in `command': git '--git-dir=/home/runner/work/open.ribose.com/open.ribose.com/_projects/Nereon/_software/libnereon/.git' '--work-tree=/home/runner/work/open.ribose.com/open.ribose.com/_projects/Nereon/_software/libnereon' '-c' 'color.ui=false' checkout '--force' 'origin/main' 2>&1:error: pathspec 'origin/main' did not match any file(s) known to git (Git::GitExecuteError)
15
from /home/runner/work/open.ribose.com/open.ribose.com/vendor/bundle/ruby/3.0.0/gems/git-1.9.1/lib/git/lib.rb:763:in `checkout'
16
The git branch of libnereon
is supposed to be master
, but the theme fetches it using main
here.
@ronaldtse
I’m still investigating but shouldn’t libnereon
specify repo_branch
here? https://github.com/riboseinc/nereon.com/blob/master/_software/libnereon.md
Per theme’s implementation of customizable branch names, wherever properties repo_url
, git_repo_url
, github_repo_url
are used, sibling properties repo_branch
, git_repo_branch
, github_repo_branch
must be provided if the specified repository is using branch name different from global default.
@strogonoff I didn't know that it will pull recursively the sites and require all the underlying configuration to be correct. We can update that for sure.
@strogonoff I didn't know that it will pull recursively the sites and require all the underlying configuration to be correct. We can update that for sure.
@ronaldtse I think it does. I wrote this a while ago, so it slipped my mind too. See how fetch_and_read_projects
method also calls fetch_and_read_software
, and does the same for specs.
I’m not sure there’s any other purpose for this beyond showing latest commit timestamps on software/spec listing pages, but it could be that we planned to do more with it.
Also, I worry there may be a deficiency where per-project global branch overrides (in projects’ Jekyll config.yml files) don’t have effect on software repos during hub site build (since it doesn’t read per-project config.yml). I’ll double-check and update the docs if so. I’m not sure it’s causing a failure now, but to be safe we should probably avoid specifying default_repo_branch
in project-wide config.yml files, and just assume the branch is main
and wherever repos use master
we should explicitly specify *_repo_branch: master
.
@strogonoff I didn't know that it will pull recursively the sites and require all the underlying configuration to be correct. We can update that for sure.
I think this helps, so I’m updating Ribose Open sites right now.
@strogonoff thanks! Can you please help update those sites? Hard for me to follow 👍
@strogonoff thanks! Can you please help update those sites? Hard for me to follow 👍
Branch references in this & project repositories were fixed so the rt-update-open-project
branch builds now. Merging?
Merged
For @strogonoff