Closed skalee closed 7 years ago
Nice!
I think we should make it only check the final APIB output file, i.e. apiary.apib
, because all other files can only be considered as inputs and thus are not representational.
The other thing is, I haven't found a way yet to specify empty strings as sample values in APIB, which is why you'd see warnings about having no specified values.
I suppose checking sections/*.apib
may be useful as well. Output is more useful than for the aggregated document because it tells you issue location precisely.
OK, got your point.
@ribose-jeffreylau Why not:
+ `s`: `""` (string) - pagination synchronization string
or
+ `s` (string) - pagination synchronization string
instead of:
+ `s`: (string) - pagination synchronization string
Both do pass in my validator.
@ronaldtse Might be a good idea to enable Travis for this repository.
Regarding the aggregated document validity, the current result is as follows:
Checking apiary.apib… FAIL
warning code 5 in line 195 - ignorning unrecognized block:
[comment]: <> (REFERENCE section)
warning code 6 in line 2667 - no value(s) specified:
`body`: (string) - Body of invitation message to the invitees
warning code 6 in line 2705 - no value(s) specified:
`s`: (string) - pagination synchronization string
warning code 6 in line 2800 - no value(s) specified:
`s`: (string) - pagination synchronization string
warning code 6 in line 2843 - no value(s) specified:
`body`: (string) - Body of invitation message to the invitees
warning code 6 in line 2941 - no value(s) specified:
`s`: (string) - pagination synchronization string
warning code 2 in line 3032 - action with method 'PUT' already defined for resource '/invitations/join_space_request/{invitation_id}':
#### Updating pre-assigned role [PUT]
warning code 6 in line 3067 - no value(s) specified:
`s`: (string) - pagination synchronization string
So we got three kinds of warnings.
warning code 6 - no value(s) specified
– as reported earlier by Jeffreywarning code 2 - action with method 'PUT' already defined for resource…
– looks like a real issue to me, comes from:
### Join Space Request [/invitations/join_space_request/{invitation_id}]
…
#### Accepting / Rejecting a.k.a Ignoring [PUT]
…
#### Updating pre-assigned role [PUT]
…
warning code 5 - ignorning unrecognized block
– no idea whether it's a true issue or a false positive@skalee enabled Travis. Let's merge this for now and keep the warnings to separate issues. Thanks!
Created #35, #36, and #37.
This is an initial version of Drafter-based validator. Comments are welcome.
Fixes #33.