riboseinc / ribose-api

API for Ribose
0 stars 0 forks source link

Resource '/settings' is already defined validation error #38

Closed skalee closed 6 years ago

skalee commented 6 years ago

Validator says:

warning code 2 in line 3197 - the resource '/settings' is already defined:
    ### Settings [/settings]

It's bit weird, and requires investigation. Problem may come from following document structure where we first define /settings/general, and then /settings, I don't know…

## Group Settings
### General Settings [/settings/general]
### Settings [/settings]
skalee commented 6 years ago

Actually, there are two definitions of GET /settings. One by @kevinwongso introduced in 0e7a2600ed53146e5e2a489a0a4f0d4b61eb98df on Wed Nov 8, and another one by @ribose-jeffreylau in b8dfd050dc661198890d6282ba66f0bacfa3b15c on Tue Nov 7.

I'm going to keep the @kevinwongso's one as it's newer and more complete. The @ribose-jeffreylau's one is more like a documentation stub, and contains only:

## Group General

### Request settings [GET /settings]

+ Request (application/json)

+ Response 200 (application/json)
ribose-jeffreylau commented 6 years ago

@skalee Yes, please go for it :) Thanks!