riboseinc / sse-elements

Tools & widgets for implementing static site editor (structured data entry) frontends in Electron
MIT License
0 stars 0 forks source link

Bundle CI signing script, possibly as part of SSE app template repository #7

Open strogonoff opened 4 years ago

strogonoff commented 4 years ago

The script is available here, but unfortunately is not generic since appId is hard-coded: https://github.com/ituob/itu-ob-editor/pull/67/files#diff-7a7cfc8a4b4382392400fa3f560add38R19

It’ll be trivial to read appId from package.json. Perhaps the signing script and other scaffolding can be bundled in app template, available through app factory script part of SSE, or via a separate template repository accompanying this one.

ronaldtse commented 4 years ago

@strogonoff this is how others have done it via Typescript: https://github.com/dino-dna/checkup/blob/master/scripts/hooks/after-sign.ts

strogonoff commented 4 years ago

Thanks for the pointer!

The idea in this issue is to bundle a way to bring up a new app from template, also covering the signing and CI.

On 6 Dec 2019, at 6:27 PM, Ronald Tse notifications@github.com wrote:

 @strogonoff this is how others have done it vis Typescript: https://github.com/dino-dna/checkup/blob/master/scripts/hooks/after-sign.ts

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.