search

riboseinc / terraform-aws-codecommit-sqs

Terraform module for creating an AWS CodeCommit repo with Trigger for SQS and Queue that works with Jenkins CodeCommit Trigger Plugin
Apache License 2.0
6 stars 5 forks source link

Terraform 12 #4

Closed jseiser closed 4 years ago

jseiser commented 4 years ago

This should work for Terraform 12.

You would/will want to cut a version 11 compatible branch.

ronaldtse commented 4 years ago

Thank you @jseiser !

@phuonghuynh could you help review, tag a release for terraform v11 (make a separate branch for it), and merge this PR to master if okay? Thanks!

phuonghuynh commented 4 years ago

Yes

ronaldtse commented 4 years ago

@ronaldtse should we add GHA workflow to run terraform validate?

Yes please, thanks @CAMOBAP795 !

jseiser commented 4 years ago

@ronaldtse @phuonghuynh

You guys may want to update the README, and the terraform registry entry, to specify which versions track 11 and 12.