search

riboseinc / terraform-aws-s3-cloudfront-website

Terraform module for creating a static S3 website with CloudFront with an SSL certificate (e.g., from ACM)
Apache License 2.0
74 stars 40 forks source link

`allowed_ips` is not allowed now #36

Closed ronaldtse closed 2 years ago

ronaldtse commented 3 years ago

@phuonghuynh the attribute allowed_ips is no longer allowed, we should remove that from the README.

ronaldtse commented 3 years ago

For @phuonghuynh . Thanks.

phuonghuynh commented 3 years ago

@ronaldtse "allowed_ips" is using in S3 to restrict IP-Sources accessibly. Should we remove this variable from the Terraform module?

ronaldtse commented 3 years ago

@phuonghuynh I thought it didn't work because there was a warning I received when using the module. If the variable is still accepted, let's keep it. Thanks.

phuonghuynh commented 2 years ago

So we keep variable "allowed_ips" as comment to support restrict IP source accessibility.