riboseinc / terraform-aws-s3-cloudfront-website

Terraform module for creating a static S3 website with CloudFront with an SSL certificate (e.g., from ACM)
Apache License 2.0
74 stars 40 forks source link

Fix Tag "Name" is always follow `fqdn` value #40

Closed vKongv closed 2 years ago

vKongv commented 2 years ago

Fix an issue where fqdn might contains value that is not allowed as part of tag value: https://docs.aws.amazon.com/directoryservice/latest/devguide/API_Tag.html which the user need to override the tag value in order to be deployed successfully.

Related to: https://github.com/riboseinc/terraform-aws-s3-cloudfront-website/issues/39

ronaldtse commented 2 years ago

Thank you @vKongv for this!

@phuonghuynh could you help review, merge and release a new version if it's okay? Thanks!

phuonghuynh commented 2 years ago

Thanks @vKongv