search

riboseinc / terraform-aws-s3-cloudfront-website

Terraform module for creating a static S3 website with CloudFront with an SSL certificate (e.g., from ACM)
Apache License 2.0
74 stars 40 forks source link

Use aws_s3_bucket's website_endpoint for cloudfront origin domain name #6

Closed colindean closed 6 years ago

colindean commented 6 years ago

This works as of AWS provider 1.37.

This seems to indicate that https://github.com/terraform-providers/terraform-provider-aws/issues/1117 has been fixed.

colindean commented 6 years ago

I just tried this out, new bucket and everything. I used the same config I'd been using but with a different domain, cleared .terraform, and used my patched version of this module:

module "main" {
  source = "git::https://github.com/colindean/terraform-aws-s3-cloudfront-website.git?ref=patch-1"#"github.com/riboseinc/terraform-aws-s3-cloudfront-website"
…
}
colindean commented 6 years ago

Well, the S3 bucket website works, the CloudFront domain name works, and I'm just waiting for DNS propagation to verify the public FQDN for the intended subdomain.

colindean commented 6 years ago

FQDN works 👍

ronaldtse commented 6 years ago

Thank you @colindean ! I've confirmed the "dot" syntax works, and let's merge this.