search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Support different ways of writing IPv6 addresses #101

Closed skalee closed 6 years ago

skalee commented 6 years ago

RFC 4291 defines a shortened notation for IPv6 addresses, and that should be taken into account when comparing host names. For instance, 0:0:0:0:0:0:0:1, and ::1 are equivalent.

codecov[bot] commented 6 years ago

Codecov Report

Merging #101 into master will increase coverage by 0.22%. The diff coverage is 98.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   97.46%   97.68%   +0.22%     
==========================================
  Files          12       14       +2     
  Lines         237      303      +66     
==========================================
+ Hits          231      296      +65     
- Misses          6        7       +1
Impacted Files Coverage Δ
lib/uri_format_validator/util.rb 100% <100%> (ø)
lib/uri_format_validator.rb 100% <100%> (ø) :arrow_up:
spec/util_spec.rb 100% <100%> (ø)
lib/uri_format_validator/constraints.rb 97.14% <83.33%> (-2.86%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12707d4...b22330f. Read the comment docs.