search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Upgrade Rubocop style guide #104

Closed skalee closed 6 years ago

skalee commented 6 years ago

Use the most current one from Ribose: https://github.com/riboseinc/oss-guides/tree/47f845df146227a366018d69667226ee6399e49c

skalee commented 6 years ago

Issues spotted by CodeClimate are related to TODO/FIXME in the ThoughtBot's style guide we base on. Can be ignored.

codecov[bot] commented 6 years ago

Codecov Report

Merging #104 into master will increase coverage by 0.66%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   97.89%   98.55%   +0.66%     
==========================================
  Files          14       14              
  Lines         333      347      +14     
==========================================
+ Hits          326      342      +16     
+ Misses          7        5       -2
Impacted Files Coverage Δ
lib/uri_format_validator/reacher.rb 94.11% <0%> (-2.04%) :arrow_down:
lib/uri_format_validator.rb 100% <0%> (ø) :arrow_up:
spec/reacher_spec.rb 100% <0%> (ø) :arrow_up:
spec/uri_validator_spec.rb 100% <0%> (+3.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61fbd24...d9bd43f. Read the comment docs.