search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Failing builds #23

Closed skalee closed 6 years ago

skalee commented 7 years ago

Travis build script is defined to fail when there are code style violations.

@ronaldtse Could you enable Hound and/or CodeClimate, so that we can move code style checks there? I'll fix builds then. Also, token to generate coverage reports is welcome.

skalee commented 6 years ago

At the moment builds do fail for JRuby, for some weird reason. See https://travis-ci.org/riboseinc/url_validator/jobs/276274580, for instance.

skalee commented 6 years ago

Apparently, they have fixed it on their end.

skalee commented 6 years ago

Happens again. Also for rack-cleanser gem.

skalee commented 6 years ago

Seems like problem on jRuby side: travis-ci/travis-ci#8446, jruby/jruby#4789.

skalee commented 6 years ago

This build: https://travis-ci.org/riboseinc/rack-cleanser/builds/277510662 is an example that downloading jRuby sometimes works and sometimes not.

skalee commented 6 years ago

Temporarily solved with #43. JRuby build success is not required for passing CI checks.

ronaldtse commented 6 years ago

I'm just going to close this and migrate JRuby to a separate issue. Thanks!