search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Release version 0.1 #37

Closed skalee closed 7 years ago

skalee commented 7 years ago

@ronaldtse Please tell what should be done in this version. Or perhaps it's v0.1-ready already?

ronaldtse commented 7 years ago

Looks like it's ready except for the typo fix!

skalee commented 7 years ago

Also the README is bit incomplete.

ronaldtse commented 7 years ago

Are we ready to do this?

skalee commented 7 years ago

@ronaldtse I think yes. Just merged-in README improvements.

ronaldtse commented 7 years ago

Done!

skalee commented 7 years ago

My bad, @ronaldtse! I forgot to set gem's version to 0.1.0 and the 1.0.0 has been released. And probably we got bunch of breaking changes to do before this gem gets really stable. I guess it's enough to write on top of the README that we don't follow semver at the moment, and that 2.0.0 will be the first stable version?

Or should I change the gem version to 0.1.0, and we'll do another release? The 1.0.0 gem can be yanked from Rubygems then.

ronaldtse commented 7 years ago

I can yank it and re-release it no problem 👍 That would be easier than maintaining the README changes!

UPDATE: Yanked!

skalee commented 7 years ago

@ronaldtse Fixed gem version. You may need to delete Gemfile.lock and rerun bundle install on your end if you see weird errors.

skalee commented 7 years ago

One sec, I'll fix CHANGELOG entry.

ronaldtse commented 7 years ago

Oh I've just released it. We can save CHANGELOG for next time 😉

skalee commented 7 years ago

Ok.