search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Delete most of the logic, and clean-up what's left #83

Closed skalee closed 6 years ago

skalee commented 6 years ago

The previous regular-expression-based implementation was insufficient, and very difficult to improve. Therefore, most of it must be removed prior being rewritten from scratch.

codecov[bot] commented 6 years ago

Codecov Report

Merging #83 into master will decrease coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #83      +/-   ##
=========================================
- Coverage   99.44%   99.4%   -0.04%     
=========================================
  Files          10      10              
  Lines         358     168     -190     
=========================================
- Hits          356     167     -189     
+ Misses          2       1       -1
Impacted Files Coverage Δ
...b/uri_format_validator/validators/uri_validator.rb 100% <100%> (+1.23%) :arrow_up:
spec/uri_validator_spec.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee54f84...2df94b0. Read the comment docs.