search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Improve specs for `retrievability` option #86

Closed skalee closed 6 years ago

skalee commented 6 years ago

Refactor and reorganize specs to make them cleaner, simpler, and more complete.

codecov[bot] commented 6 years ago

Codecov Report

Merging #86 into master will decrease coverage by 1.66%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage    99.4%   97.74%   -1.67%     
==========================================
  Files          10       10              
  Lines         168      177       +9     
==========================================
+ Hits          167      173       +6     
- Misses          1        4       +3
Impacted Files Coverage Δ
spec/uri_validator_spec.rb 100% <100%> (ø) :arrow_up:
lib/uri_format_validator/reacher.rb 87.5% <0%> (-5.84%) :arrow_down:
...b/uri_format_validator/validators/uri_validator.rb 94.73% <0%> (-5.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1286ca7...1bb51a8. Read the comment docs.