search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Remove non-existing option from specs #87

Closed skalee closed 6 years ago

skalee commented 6 years ago

The :scheme option has been temporarily removed in 6839f41adee0b4422c (pull request #83). Providing it in these tests was the odd requirement of the previous implementation. Now it may be (and should be) removed from these examples as irrelevant.

codecov[bot] commented 6 years ago

Codecov Report

Merging #87 into master will decrease coverage by 1.68%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   99.42%   97.74%   -1.69%     
==========================================
  Files          10       10              
  Lines         174      177       +3     
==========================================
  Hits          173      173              
- Misses          1        4       +3
Impacted Files Coverage Δ
spec/uri_validator_spec.rb 100% <100%> (ø) :arrow_up:
lib/uri_format_validator/reacher.rb 87.5% <0%> (-5.84%) :arrow_down:
...b/uri_format_validator/validators/uri_validator.rb 94.73% <0%> (-5.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b41b754...d090d4d. Read the comment docs.

skalee commented 6 years ago

This one has been already fixed in a better way in #89, closing.