search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Setting option to false always disables it #91

Closed skalee closed 6 years ago

skalee commented 6 years ago

In the previous implementation, false was sometimes a meaningful setting. I think it was bit confusing, it's better to add few more symbol-based suboptions than that.

codecov[bot] commented 6 years ago

Codecov Report

Merging #91 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage    99.5%   99.52%   +0.01%     
==========================================
  Files          10       10              
  Lines         204      210       +6     
==========================================
+ Hits          203      209       +6     
  Misses          1        1
Impacted Files Coverage Δ
spec/uri_validator_spec.rb 100% <100%> (ø) :arrow_up:
...b/uri_format_validator/validators/uri_validator.rb 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8de5a1...f884821. Read the comment docs.