search

riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Fix checks for URL retrievability #98

Closed skalee closed 6 years ago

skalee commented 6 years ago

Specs were marked as pending due to #62. However, the predefined list of allowed schemes is no longer on master, so they should be re-enabled now. They were still failing due to bug in Reacher class, which is fixed in this pull request.

codecov[bot] commented 6 years ago

Codecov Report

Merging #98 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   99.63%   99.64%   +<.01%     
==========================================
  Files          10       10              
  Lines         276      278       +2     
==========================================
+ Hits          275      277       +2     
  Misses          1        1
Impacted Files Coverage Δ
spec/uri_validator_spec.rb 100% <100%> (ø) :arrow_up:
spec/reacher_spec.rb 100% <100%> (ø) :arrow_up:
lib/uri_format_validator/reacher.rb 94.11% <100%> (+0.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f93e2c...8ac7d3a. Read the comment docs.