riboseinc / uri_format_validator

Validate URL for Rails
MIT License
3 stars 2 forks source link

Allow specifying URI constraints with accept and reject lists #99

Closed skalee closed 6 years ago

skalee commented 6 years ago

As discussed in #75. More documentation (in form of Cucumber examples) is still needed.

codecov[bot] commented 6 years ago

Codecov Report

Merging #99 into master will decrease coverage by 0.9%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   99.64%   98.73%   -0.91%     
==========================================
  Files          10       12       +2     
  Lines         278      237      -41     
==========================================
- Hits          277      234      -43     
- Misses          1        3       +2
Impacted Files Coverage Δ
lib/uri_format_validator/constraints.rb 100% <100%> (ø)
spec/uri_validator_spec.rb 100% <100%> (ø) :arrow_up:
...b/uri_format_validator/validators/uri_validator.rb 100% <100%> (ø) :arrow_up:
lib/uri_format_validator.rb 100% <100%> (ø) :arrow_up:
spec/helper_methods_spec.rb 80% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb4c607...5125b05. Read the comment docs.

ronaldtse commented 6 years ago

@skalee ready to merge this? Thanks!

skalee commented 6 years ago

I've created this pull request bit prematurely. Will complete feature specs and merge then.

ronaldtse commented 6 years ago

No problem. Anytime you're ready!

ronaldtse commented 6 years ago

Thanks @skalee !