Makes Pig thread safe - Githubissues

ribot / pig

Pig aims to be the bridge in the middle of your native mobile UI and a some shared JavaScript business logic.

Other

11 stars 1 forks source link

Makes Pig thread safe #7

Closed ivacf closed 10 years ago

ivacf commented 10 years ago

Use ConcurrentHashMap instead of HashMap
Add synchronized to addListener and removeListener methods because they use a HashSet that is not thread safe.

matt-oakes commented 10 years ago

I did spot this after I talk to you: http://possiblelossofprecision.net/?p=813

If you wrap the Set creation in Collections.synchronizedSet( ... ) then you might not need to block on the entire function.

It's only a really minor point though because there's are big or often used methods.

ivacf commented 10 years ago

Yeah I saw it too but I wasn't sure that would work .I guess it's not a really big difference and most of the time Pig wil be used form the main thread.