riboviz / example-datasets

Example datasets to run with RiboViz
Apache License 2.0
2 stars 7 forks source link

Add new dataset for Homo sapien from Iwasaki et. al. Mol. Cell 2019 #93

Closed acope3 closed 2 years ago

acope3 commented 3 years ago

See https://doi.org/10.1016/j.molcel.2018.11.026.

Thanks for starting to add a new dataset to example-datasets! This issue template includes the key steps, see add-new-dataset.md. Please edit as needed for your dataset.

acope3 commented 3 years ago

One thing I noticed is much of the code in generate_stats_figs.R assumes the CDS was created using a buffer as opposed to annotated UTRs. I've updated this as part of a local branch that I will push later after performing the regression tests. To give you an idea of how this impacts the results.

Here is what the position specific RPF normalized reads look like with the current code in the develop branch.

pos_sp_rpf_norm_reads-Iwasaki_etal_2019-develop_branch.pdf

And here is what it looks like using my local code that takes the start and end of the CDS from the GFF3 file.

pos_sp_rpf_norm_reads-Iwasaki_etal_2019-local_branch.pdf

acope3 commented 3 years ago

See pull request #96

FlicAnderson commented 3 years ago

I'm planning to review this when I link it to reviewing riboviz/#207 after @acope3 has updated that branch (sra_download_207_acope3).

FlicAnderson commented 2 years ago

Dataset run, checked, config updated, merged to main, closing :) Great stuff @acope3!