Prettier, eslint, gitignore

[swazrgb]

Would you accept a PR that adds prettier to reformat the code, eslint for linting and adds the files generated by geninstr.ts to the gitignore?

• Prettier will reformat the code using standardized rules
• ESLint can be used to find potential problems, such as forgetting to write await on an async function and a many other checks
• Adding the generated files to gitignore will reduce merge conflicts, but would require anyone working on the repo to run the geninstr command any time they clone or switch branches.

I would propose to exclude dsconvert.js from formatting & linting errors since it's vendored from DesyncedJavaScriptUtils.

Running prettier on compile.ts & assemble.ts would be a pretty big diff, prone to merge conflicts. Such merge conflicts are relatively easy to resolve by also running prettier on the branch that is being merged, but it would be good to coordinate this.

Thanks!

[ribrdb]

Prettier sounds good. I'm a little unsure about eslint, I'd want to see what/how much it screams about. Maybe do that one separately?

I'm also not sure about gitignore for the generated files. It's kind of tricky to generate them, although it's at least documented how to do it now.

[swazrgb]

I'm also not sure about gitignore for the generated files

I would propose keeping the .json file(s) extracted from the game, but ignoring the other source files, they only require running a single node command which could be implemented as npm run generate.

[ribrdb]

I didn't include that one in particular because I thought the game devs might not like it. Although the other files contain most of the same info, so maybe it's not any different?

[swazrgb]

I asked beatwho (Co-Founder of Stage Games Inc.) for permission to redistribute the data.json produced by my Data Dump mod, which includes this data and more:

So we could distribute only the json file, and have everything else be generated (at runtime, where feasable).

[ribrdb]

Ok awesome!