ribru17 / bamboo.nvim

Warm Green Theme for Neovim and Beyond
Other
320 stars 11 forks source link

Customize float border to be more consistent with config parameters #11

Closed vihu closed 1 year ago

vihu commented 1 year ago

Summary

I find the changes here to be marginally more visually consistent (especially with plugins like fzf-lua and lspconfig which show floating windows for docs, search etc) if the user has specified dim_inactive and/or transparent config settings.

Merging this is really upto you @ribru17, please feel free to edit as necessary. If you dislike it I'm happy to continue using my fork. I just thought I'd make the PR regardless.

ribru17 commented 1 year ago

Thanks for the PR! I'll take a look at this soon, a bit busy right now

ribru17 commented 1 year ago

Thanks for the changes! I tweaked one or two things to make everything simpler but overall the functionality should be the same as in your initial commit, minus the fact that the FloatBorder is still purple now, even when dim_inactive = false.