ribru17 / bamboo.nvim

Warm Green Theme for Neovim and Beyond
Other
320 stars 11 forks source link

comments are yellow #2

Closed WhoIsSethDaniel closed 1 year ago

WhoIsSethDaniel commented 1 year ago

Everywhere in the highlights.lua file comments seems to be c.grey. However, when defining @comment they are set to c.bg_yellow. Was this a mistake?

I attempted to overwrite this in the setup() doing this:

require('bamboo').setup {
  highlights =  {
   ['@comment'] = { fg = '$grey' },
  }
}

but I still get yellow comments...once semantic tokens come in from the language server. For now I've changed the code to c.grey in highlights.lua.

I like the theme, except for comments.

ribru17 commented 1 year ago

Thanks for reporting, I'll take a look at the semantic tokens overriding the user customizations, this should not happen. The yellow comments, however, are intentional for better contrast and readability. This is mentioned briefly in the README. I will be changing all other references of grey comments to yellow, seems I missed a bunch of occurrences. But anyway you should be able to change them to your liking without semantic tokens interfering. I will get working on this soon

WhoIsSethDaniel commented 1 year ago

Thank you for the explanation.

ribru17 commented 1 year ago

Of course. This should be fixed now, let me know if you still get any issues with the custom highlighting

WhoIsSethDaniel commented 1 year ago

worked great. Thank you.