ribtoks / tdg-github-action

GitHub action for project management using TODO comments
MIT License
58 stars 5 forks source link

Log commit author and skip assign issues not created #63

Closed sidsprasad closed 9 months ago

sidsprasad commented 9 months ago
sidsprasad commented 9 months ago

@ribtoks While running in my repo, I came across two issues.

  1. If the issue wasn't created in the first place, it still tries assigning the author, so added a condition to skip that over here.
  2. All the issues were being assigned to me for some reason. So, logging the commit hash here, and will verify with the API why it is getting me as the author. Also good to log this info anyway.
sidsprasad commented 9 months ago

@ribtoks I ran this again on my repo and the issue is that the Commit API was never actually called.

So there's two possible reasons for this:

  1. tdg doesn't return commithash properly and so Line 381 is never true.
  2. commitToAuthorCache is misbehaving, and Line 357 is always returning hits. This is more likely the cause as the size of issueTitleToAssigneeMap is correct.

Will create another PR to add another line of logging to confirm this.