New Feature: Ability to add a custom view with a single image to the ActionBar.

ricardoalcocer / actionbarextras

Titanium Android Native Module that exposes ActionBar features not exposed by the Titanium SDK

MIT License

148 stars 60 forks source link

New Feature: Ability to add a custom view with a single image to the ActionBar. #105

Closed asiby closed 8 years ago

asiby commented 8 years ago

This pull request will add a new feature as discussed at #104

Features:

Replace the title and subtitle of the ActionBar to an image.
Restore the title and subtitle of the ActionBar to their previous state.
The other icons and properties of the ActionBar stay unaltered.
The test harness example application has been updated to support this new feature.
The documentation has been updated.
The version has been bumped to 1.6.10

Cheers

asiby commented 8 years ago

I have noticed that I have accidentally left some Log.i() statements in there. So before merging, you might want to delete them or change them into Log.d() so that the module doesn't flood the console.

asiby commented 8 years ago

I already have a patch to apply after #105. It solves an issue related to module caching in Alloy. An important variable was persisting across instances of ABX. I will prepare it and submit it.

manumaticx commented 8 years ago

Wow - this is an awesome pull request. I'm going to test and merge this as soon as possible.

Thank you! 👍

asiby commented 8 years ago

You are very welcome. I am already using it in production now.

manumaticx commented 8 years ago

This is really awesome. I've tested it, it works like a charm. The code looks pretty. All good. Merged. Cheers