search

ricardoamaro / drupalci_testbot

This is a testing version of Drupal testbot using docker containers. Please use:
https://drupal.org/project/drupalci_testbot
MIT License
53 stars 21 forks source link

Fixed PostgreSQL support and added MariaDB support #12

Closed jaredsmith closed 10 years ago

jaredsmith commented 10 years ago

I've done some more hacking on the Docker setup, and have fixed the PostgreSQL locale issues, as well as added MariaDB support at the request of jthorson.

ricardoamaro commented 10 years ago

Hey Jared,

Thank you very much for this work! There are a couple of things that need to be fixed before merging:

1 - You need to rebase on the actual master, because there are several fixes i added to the setup and to the Postgresql eg. give pgsql createdb perms to the user See here the latest changes: https://github.com/ricardoamaro/modernizing_testbot__dockerfiles/commits/master

2 - I left you a message on Druplicon but maybe you didn't see it. Looks like there is a pending issue with pgsql D8 setup that seems blocked by: https://drupal.org/node/2010368 So i created https://drupal.org/node/2282083

3 - The MariaDB container is also missing a couple of modifications so it does not delete/overlap other running db containers. See latest mysql tree. :)

It would be awesome if you could resolve these files and it's great to have you helping on this :) Please request another pull request when those are fixed.

ricardoamaro commented 10 years ago

looks great merging