#92: add a second footnote that explains the colors

ricardoboss / Prolangle

A game about programming languages.

https://prolangle.ricardoboss.de

MIT License

2 stars 1 forks source link

#92: add a second footnote that explains the colors #101

Closed chucker closed 5 months ago

chucker commented 5 months ago

I'm not sure about this. It's kinda busy.

And yes, there's some code duplication. I guess we could use CSS variables here?

ricardoboss commented 5 months ago

I like it! If you want, you could move the colors to CSS variables and use them in the other components as well.

I'd say:

--color-exact and --color-on-exact
--color-partial and --color-on-partial and finally
--color-no-match and --color-on-no-match

Would be good names. What do you think?

chucker commented 5 months ago

I don't know what -on- means in this context. How's https://github.com/ricardoboss/Prolangle/pull/101/commits/6d685aaa37e5080e20943e2d4c5030b51490f571?

ricardoboss commented 5 months ago

I don't know what -on- means in this context. How's 6d685aa?

-on- is the infix referring to the color that has a high contrast when drawn over the color, i.e. a fitting text color. It's a pattern I got used to and it served me well.

ricardoboss commented 5 months ago

@chucker I changed the style of the example texts a bit, ok to merge?