Closed chucker closed 8 months ago
I'm unsure about the dependency. It's quite heavy, and we only really need one service from it. But forking it also means continuous maintenance.
Oh, and this doesn't support multiple layers of headers. I think we don't really need that, for now.
I'm unsure about the dependency. It's quite heavy, and we only really need one service from it. But forking it also means continuous maintenance.
Yeah, really not a fan of a second component library. I also agree adding more code than necessary means more maintenance for us.
Not sure if a ToC is worth the effort of maintaining either of those solutions...
Apart from that it looks and functions as expected. GJ
I also agree adding more code than necessary means more maintenance for us.
Yeah.
There's a third solution of "offer a PR to MudBlazor that provides a NuGet with must this one service". But I don't really want to put that work in.
I might look into manually tree-shaking this stuff. A fork that throws must MudBlazor code out and just leaves the code we need. Not sure how much work that is, though.
How about option four: petition Blazorise to offer a MudBlazor-like scroll handler?
Apart from that it looks and functions as expected. GJ
:)
How about option four: petition Blazorise to offer a MudBlazor-like scroll handler?
I don't think Blazorise will provide components on this level. They should, however, provide a service for scroll spy. Maintaining one of our own would be my preferred option until then. (Ideally it should be a separate project/nuget package)
This needs to be rebased (a version was already release since this was opened). Afterwards, we can merge this, I think
fixes #113