ricardochimal / taps

simple database import/export app
MIT License
1.2k stars 140 forks source link

undeclared dependency on hoptoad_notifier #75

Closed alexch closed 13 years ago

alexch commented 13 years ago

"taps server" apparently depends upon hoptoad_notifier, but that dependency isn't declared in the gemspec.

symptom: no such file to load -- hoptoad_notifier

workaround: [sudo] gem install hoptoad_notifier

Not sure if the solution is to add the dependency or remove the code (or make it fall back gracefully).

ddollar commented 13 years ago

Gems that are specific to the "server" component are only defined in the Gemfile, in the :server group. The .gemspec dependencies are only for the client.

Cheers, David

alexch commented 13 years ago

Fair enough, but then consider this a documentation bug. Please amend the readme to include the appropriate bundler command line.

Actually, wait a second -- is there an appropriate bundler command line? Where's the Gemfile? If I do "gem install taps" on my server then I'm probably nowhere near the gem install dir that has the Gemfile, so bundler won't work.

I think maybe you need to add the dependency to the gemspec after all. Or add "gem install hoptoad_notifier" to the readme.

ddollar commented 13 years ago

I updated the README with new instructions for starting a server.

alexch commented 13 years ago

Kudos for the instant gratification, but really? You'd rather have users jump through all those git and bundler hoops rather than just stick a "gem install hoptoad_notifier" in there?

ddollar commented 13 years ago

Moved the hoptoad_notifier require into a rescue with notification, and moved back to the old server start instructions.

Thanks for the feedback!

alexch commented 13 years ago

Yippee! :-)