search

ricardoekm / Kyrix

Interactive pan/zoom data visualizations at scale
0 stars 0 forks source link

Move configuration to key-value #8

Open ricardoekm opened 5 years ago

ricardoekm commented 5 years ago

Related to #3 .

Rely on line position for configuration makes it hard to read and write the file and is fragile. This also makes impossible to add comments to the config.

The recommended approach usually is to use a key-value implementation (.json for Javascript or .properties for Java). Javascript has native support for .json, which makes it the natural choice.

https://github.com/ricardoekm/Kyrix/blob/0ce6879a307f1d16440ef79fa978d9dc529020a2/compiler/src/index.js#L23-L30

Splitting the configuration of the compiler and the back-end and using .json + Config Module seems a good option.

tracyhenry commented 4 years ago

Yes, also tracked here: https://github.com/tracyhenry/Kyrix/issues/64