search

ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

Support for xo #110

Closed LinusU closed 8 years ago

LinusU commented 8 years ago

How about adding support for xo? Thanks!

tcarlsen commented 8 years ago

use this: https://github.com/sindresorhus/atom-linter-xo

ricardofbarros commented 8 years ago

Thank you @tcarlsen

LinusU commented 8 years ago

@ricardofbarros @tcarlsen The thing I love about this package is that it automatically finds the appropriate linter to use from the package.json. I don't personally use xo, but ever so often I need to edit projects that does. Instead of getting errors on almost every single row, it would be nice if it would automatically detect xo and show those rules instead.

semistandard and happiness is implemented, so why not xo?

LinusU commented 8 years ago

ping @ricardofbarros, would you mind reading my last comment and please reconsider?

ricardofbarros commented 8 years ago

Hey @LinusU, I stand with @tcarlsen opinion, you should have both linters installed, and from a quick look at atom-linter-xo it only lints if xo is a dependency or devDependency in your project package.json. So you could use both linters without a problem. I could add xo support in the future, but I want to minimize the options of linter we have than rather increase them.

LinusU commented 8 years ago

Thank you for taking the time to answer. While I do not share your outlook on this, I do respect your decision. edit: actually since this package is linter-js-standard it make sense

For anyone else finding this, ticking "Check for standard" helped a lot 👍 That way it won't complain when another style guide is in use...