search

ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

Object.extname is deprecated. #150

Closed dflock closed 7 years ago

dflock commented 8 years ago

Atom 1.13.0-beta2 deprecation cop says:

Argument to path.extname must be a string

Object.extname (/usr/share/atom-beta/resources/app.asar/src/electron-shims.js:20:10)
processText (/home/duncan/.atom/packages/linter-js-standard/node_modules/standard/node_modules/eslint/lib/cli-engine.js:191:30)
CLIEngine.executeOnText (/home/duncan/.atom/packages/linter-js-standard/node_modules/standard/node_modules/eslint/lib/cli-engine.js:678:26)
Linter.lintText (/home/duncan/.atom/packages/linter-js-standard/node_modules/standard/node_modules/standard-engine/index.js:60:54)
<unknown> (/home/duncan/.atom/packages/linter-js-standard/lib/linter-js-standard.js:18:20)
exports.allowUnsafeNewFunction (/home/duncan/.atom/packages/linter-js-standard/node_modules/loophole/lib/loophole.js:25:14)
ricardofbarros commented 7 years ago

Hey @dflock , I'm not seeing that deprecated call on my atom.

Atom 1.14.3

dflock commented 7 years ago

I'm currently on 1.15.0-beta3 and I don't see this any more either.

bronson commented 7 years ago

I just got this on 1.15.0.

Trace appears to be the same as dflock's:

Object.extname - /Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:20:10
processText - /Users/bronson/line-ending-selector/node_modules/eslint/lib/cli-engine.js:191:30
CLIEngine.executeOnText - /Users/bronson/line-ending-selector/node_modules/eslint/lib/cli-engine.js:678:26
Linter.lintText - /Users/bronson/line-ending-selector/node_modules/standard-engine/index.js:60:54
<unknown> - /Users/bronson/.atom/packages/linter-js-standard/lib/linter-js-standard.js:18:20
exports.allowUnsafeNewFunction - /Users/bronson/.atom/packages/linter-js-standard/node_modules/loophole/lib/loophole.js:25:14