ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

Uncaught TypeError: _this.notificationEl.querySelector is not a function #187

Closed zamabraga closed 7 years ago

zamabraga commented 7 years ago

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.17.0 x64 Electron: 1.3.15 OS: Ubuntu 16.04.2 Thrown From: linter-js-standard package 3.9.1

Stack Trace

Uncaught TypeError: _this.notificationEl.querySelector is not a function

At /home/zama/.atom/packages/linter-js-standard/node_modules/atom-package-deps/lib/view.js:22

TypeError: _this.notificationEl.querySelector is not a function
    at /packages/linter-js-standard/node_modules/atom-package-deps/lib/view.js:22:58

Commands

     -4:09.8.0 settings-view:open (atom-pane.pane.active)
  4x -3:19.1.0 core:backspace (input.hidden-input)
     -3:15.2.0 core:confirm (input.hidden-input)
  2x -2:04.2.0 core:paste (input.hidden-input)
     -1:19.8.0 command-palette:toggle (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
  4x -1:18.2.0 core:backspace (input.hidden-input)
     -1:13.8.0 core:move-down (input.hidden-input)
     -1:13.2.0 core:confirm (input.hidden-input)
     -1:13.2.0 settings-view:open (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
     -0:58.9.0 command-palette:toggle (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)
  2x -0:57.3.0 core:move-down (input.hidden-input)
     -0:56.7.0 core:confirm (input.hidden-input)
     -0:56.7.0 sync-settings:restore (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Non-Core Packages

advanced-open-file 0.16.6 
atom-material-ui 2.0.3 
atom-terminal 0.8.0 
busy-signal 1.4.1 
docblockr 0.9.4 
git-plus 7.8.0 
intentions 1.1.2 
ionide-fake 1.2.2 
ionide-fsharp 1.9.3 
ionide-fsi 2.1.3 
ionide-installer 1.4.0 
ionide-paket 2.2.6 
ionide-webview 1.0.3 
language-docker 1.1.7 
language-groovy 0.7.0 
linter 2.1.4 
linter-js-standard 3.9.1 
sync-settings 0.8.1 
Arcanemagus commented 7 years ago

@ricardofbarros Your version of atom-package-deps is 2 major versions out of date, this should be fixed in the v4 series.

natecox commented 7 years ago

@Arcanemagus on a completely fresh install of Atom I get this same error, doubtful I have anything out of date at the system level.

Error Details

Atom: 1.17.0 x64 Electron: 1.3.15 OS: Mac OS X 10.12.5 Thrown From: linter-js-standard package 3.9.1

Stack Trace

Uncaught TypeError: _this.notificationEl.querySelector is not a function

At /Users/nate/.atom/packages/linter-js-standard/node_modules/atom-package-deps/lib/view.js:22

TypeError: _this.notificationEl.querySelector is not a function
    at /packages/linter-js-standard/node_modules/atom-package-deps/lib/view.js:22:58

Commands

Non-Core Packages

firewatch-syntax 1.1.1 
linter-js-standard 3.9.1 
standard-formatter 2.8.0 
standardjs-snippets 2.6.0 
vim-mode 0.66.0 
natecox commented 7 years ago

Installing linter manually seems to have solved the issue

Arcanemagus commented 7 years ago

@natecox I tagged the package author, not you, for a reason 😉.

The required version of atom-package-deps is currently listed as ^2.0.5, but that package is currently on v4.6.0.

florianboudot commented 7 years ago

@natecox Yes ! It worked for me. I closed atom, ran apm install linter-js-standard in the terminal, reopened atom and it prompted to install a last dependency and it worked. Thanks

piersg commented 7 years ago

@natecox @florianboudot NB I had no luck with apm install linter-js-standard by itself, but apm install linter (as per nate) did result in a prompt to finish dependencies from Atom next time I launched it. Hope @ricardofbarros comes back to us soon!

dcposch commented 7 years ago

cc @feross -- this issue makes standard hard to use with atom, sad times

Lycanite commented 7 years ago

I get this error but use Nuclide which replaces Linter.

Arcanemagus commented 7 years ago

@Lycanite This has been fixed on master, but is not yet released. Note that this problem has nothing to do with which consumer you are using, but this provider here 😉.

Lycanite commented 7 years ago

Ah I see, will wait for the release then, thanks!

ernani commented 7 years ago

Same here, is there any other workaround?

sonicdoe commented 7 years ago

The workaround for now is to manually install Linter using apm install linter. Other than that, I’ll release a new version including #193 soon.

ernani commented 7 years ago

Thanks a lot! That worked!

sonicdoe commented 7 years ago

Released in v4.0.0.

knows1 commented 5 years ago

Uncaught TypeError: _this.notificationEl.querySelector is not a function