ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

disable if eslint config is present #197

Closed chee closed 7 years ago

chee commented 7 years ago

closes #194

works for me ready to make any fixes necessary

now i can leave linter-js-standard and linter-eslint enabled and comfortably switch between projects

💚❤️💜💛 。^‿^。 💛💜❤️💚

chee commented 7 years ago

it adds a dependency (find-root), but that dependency was already a dependency of an already included dependency (pkg-config)

Arcanemagus commented 7 years ago

This is a simplified version of what ESLint does, you can find documentation on that here. Over in linter-eslint we implement the entire logic here, but with an exclusion for the "home folder" config when checking the "Disable when no ESLint config" option.

sonicdoe commented 7 years ago

Thank you for the pull request, @chee. I think it would be great to split out this check into a separate module (for example, uses-eslint). Would you be interested in publishing such a package?

chee commented 7 years ago

sure, @sonicdoe, i'll do that !

chee commented 7 years ago

@sonicdoe

https://github.com/chee/detect-eslint-config i did that

https://www.npmjs.com/package/detect-eslint-config

given a file path it recursively checks for eslint config until it hits a package.json, at which point it stops.

it ignores homedir eslint config.

will update this pr to use it once i get get some :bacon: 🍳 .

chee commented 7 years ago

updated and pushed

sonicdoe commented 7 years ago

Thanks 👍