search

ricardofbarros / linter-js-standard

Atom linter plugin for JavaScript, using JavaScript Standard Style
https://atom.io/packages/linter-js-standard
MIT License
99 stars 48 forks source link

update dependencies #227

Closed jimmywarting closed 5 years ago

jimmywarting commented 5 years ago

You have 4 outdated dependencies Would you care to update? maybe also adding the greenkeeper bot?

sonicdoe commented 5 years ago

I have updated semistandard and babel-eslint on the master branch, for now. I’ll get to atom-package-deps and ignore when I can make time.

Thanks for the hint at Greenkeeper, however, I’m currently not interested in adding it to this repository.

Arcanemagus commented 5 years ago

FYI, it looks like you are already defining the package name when calling install(), and are on a 4.x version of atom-package-deps, so the 5.0.0 update should require no changes other than updating the version in package.json.

sonicdoe commented 5 years ago

Thanks for weighing in, @Arcanemagus.

I would have liked to take a closer look at when and how atom-package-deps v5 installs the latest version of a dependency. For example, if I specify linter:2.0.0 as a dependency, would atom-package-deps install linter v2.0.0 or the latest version (as long as it‘s newer than v2.0.0)?

Arcanemagus commented 5 years ago

If you specify linter:2.0.0 it will require at least that version to be installed, and will install that version if it isn't.

So if the user has linter@1.x.y installed, it will force (with a prompt?) install linter@2.0.0 exactly, meaning they will then have Atom telling them there is an update available.

If they have linter@2.0.0 or newer installed, it will simply return without doing anything.

sonicdoe commented 5 years ago

Thanks for the explanation. I’ve just tested this with a fresh installation of Atom (to test the out-of-box experience) and it seems like atom-package-deps v5 installs the latest version of linter if none is installed. I actually like this change, however, I was also running into a regression bug which I’ve reported in https://github.com/steelbrain/package-deps/issues/140.

Arcanemagus commented 5 years ago

Oh interesting, I'm not sure if that's a bug in apm or not since I thought it sent that out as a command like apm install linter@2.0.0, but in either case I'm definitely with you that installing the latest version is preferred!